Iris interface handles standard constructors enabling unit tests #709
Conversation
philippjfr
changed the title
philippjfr
force-pushed
the
iris_constructor
branch
from
1c63954
to
7364dee
Compare
|
Fixes various inconsistencies and adds better coverage. Ready to merge. |
| self.data_instance_type = iris.cube.Cube | ||
| self.init_data() | ||
|
|
||
| def test_dataset_add_dimensions_values_hm(self): |
There was a problem hiding this comment.
I assume you are doing this to disable some of the inherited tests. A docstring explaining why these tests are not enable would be good...
There was a problem hiding this comment.
Yes, sounds good. They should eventually be remove once those methods are implemented.
|
Looks good and good to support those constructors. My only worry is won't changing the way it does inclusive/exclusive bounds be an issue for backwards compatibility? Perhaps I'm missing something... |
Backwards compatibility for the Iris backend? I guess so, but it was a bug since it was inconsistent with the other interfaces. |
|
Ok, as long as that is clear. I agree consistency is more important, especially as this interface is new. I'm happy to merge now, although maybe you might like to implement my |
|
I'll do that quickly in addition to adding a comments about the disabled tests. |
|
Done. Ready to merge. |
|
Looks good. Merging. |
This PR allows the iris interface to handle the standard tuple and dict based constructors making it equivalent to the grid interface. This means all the unit tests, except for aggregation and sampling (which are not yet implemented), can be shared across the two interfaces.